Skip to content
Discussion options

You must be logged in to vote

Good find, Shantanu.

shall I create a PR with all of existing usages of get in other runtime objects replaced with the above fix?

The problem here is that get(meta, ...) is calling the member function, but it used to be calling runtime::get, since we're in the runtime namespace and get was accessible without qualification. So the most minimal port is to audit the unqualified get calls in objects to see if they need to be runtime::get.

However, all runtime::get does these days is call the member function, so this is an appropriate time to manually inline any of these which need to be changed anyway, by just using the member function directly rather than using runtime::get. We'll still ke…

Replies: 1 comment 3 replies

Comment options

You must be logged in to vote
3 replies
@shantanu-sardesai
Comment options

shantanu-sardesai Feb 9, 2026
Collaborator Author

@jeaye
Comment options

jeaye Feb 9, 2026
Maintainer

Answer selected by shantanu-sardesai
@shantanu-sardesai
Comment options

shantanu-sardesai Feb 9, 2026
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:compiler Lexer, parser, analyzer, codegen.
2 participants