Error printing collections when items are Clojure functions #689
-
Issue DescriptionThere is a possible regression in jank wherein using Clojure functions as collection items causes a runtime error. Still looking into it further, but this was an issue I noticed in my local build and also in the I've also chosen to ignore the warning on the health check of my Reproduction StepsSetup: All cause the following error: jank health checkFor my local build: For my Stack traceOS Version InformationMacOS Sequoia v15.7.3 I acknowledge that:
|
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
UPDATE: It looks like the issue is with printing a collection, so the following doesn't cause the same issue: Seems like it might be a bug in the to_string implementation of I've yet to fully catch-up on the latest object model changes, but it might be that currently the Yep, swapping out the current auto const name(meta->get(__rt_ctx->intern_keyword("name").expect_ok()));@jeaye, shall I create a PR with all of existing usages of |
Beta Was this translation helpful? Give feedback.
Good find, Shantanu.
The problem here is that
get(meta, ...)is calling the member function, but it used to be callingruntime::get, since we're in theruntimenamespace andgetwas accessible without qualification. So the most minimal port is to audit the unqualifiedgetcalls in objects to see if they need to beruntime::get.However, all
runtime::getdoes these days is call the member function, so this is an appropriate time to manually inline any of these which need to be changed anyway, by just using the member function directly rather than usingruntime::get. We'll still ke…