SLANG Add rule to detect slice equality functions that can use slices…#339
Closed
paulnegz wants to merge 1 commit intoSonarSource:masterfrom
Closed
SLANG Add rule to detect slice equality functions that can use slices…#339paulnegz wants to merge 1 commit intoSonarSource:masterfrom
paulnegz wants to merge 1 commit intoSonarSource:masterfrom
Conversation
….Equal * Implements SliceEqualSimplificationCheck to detect custom slice equality functions that can be replaced with Go's built-in slices.Equal() function * Detects functions with 2 parameters that contain len() comparisons * Includes comprehensive test coverage with SLang syntax examples * Addresses refactoring opportunity similar to ollama/ollama#11502 This rule helps Go developers modernize their code by identifying opportunities to use the standard library's optimized slice comparison instead of custom implementations.
Author
|
@irina-batinic-sonarsource I'll appreciate if I can get a review and feedback for this. Open to making adjustments to move this forward |
Contributor
|
Hi @paulnegz, Cheers, Dorian |
Contributor
|
Hi @paulnegz |
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….Equal
This rule helps Go developers modernize their code by identifying opportunities to use the standard library's optimized slice comparison instead of custom implementations.
Part of