fix(tvf): validate non-negative width and height in pattern_match#17515
Open
linxt20 wants to merge 1 commit intoapache:masterfrom
Open
fix(tvf): validate non-negative width and height in pattern_match#17515linxt20 wants to merge 1 commit intoapache:masterfrom
linxt20 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add validation for negative
widthandheightparameters in thepattern_matchtable-valued function. Previously, passing a negative value for either parameter was silently accepted and produced an empty result set with no indication of misuse, which is inconsistent with howsmoothandthresholdare already validated.Changes
PatternMatchTableFunction.analyze(): Add non-negative checks forWIDTH_PARAMandHEIGHT_PARAM. A negative value now throwsUDFExceptionwith a clear message, matching the existing behavior ofsmooth/threshold.IoTDBWindowTVFIT: Add two integration test cases asserting thatwidth => -1.0andheight => -10.0are rejected with the expected error messages.Before
After
Type of change
Compatibility
No behavioral change for valid (non-negative) inputs. Only previously-undefined behavior with negative inputs is now rejected at analysis time.