compose-file: note that environment source isn't supported by stack deploy#24812
Open
lacatoire wants to merge 2 commits intodocker:mainfrom
Open
compose-file: note that environment source isn't supported by stack deploy#24812lacatoire wants to merge 2 commits intodocker:mainfrom
lacatoire wants to merge 2 commits intodocker:mainfrom
Conversation
…eploy docker stack deploy goes through cli/compose/convert which only reads the file source and ignores environment. The command fails to read the secret or config when only environment is set. Closes docker#23678
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a callout on both
secrets.mdandconfigs.mdreference pages explaining that theenvironmentsource is honored bydocker composebut causesdocker stack deployto fail, withfileorexternalas the workaround.Verified against
docker/clicli/compose/convert/compose.gowherefileObjectConfig()only readsobj.File. When onlyenvironment:is set,os.ReadFile("")surfaces an error and the stack deploy fails.Closes #23678