Skip to content

Update Dockerfile code snippet for "Using the official Docker image" tab#24820

Open
iamdbychkov wants to merge 1 commit intodocker:mainfrom
iamdbychkov:patch-2
Open

Update Dockerfile code snippet for "Using the official Docker image" tab#24820
iamdbychkov wants to merge 1 commit intodocker:mainfrom
iamdbychkov:patch-2

Conversation

@iamdbychkov
Copy link
Copy Markdown
Contributor

The code snippet for Dockerfile under the "Using the official Docker images" contains a comment which says that this Docker file uses DHI image, which is incorrect.

Updated the code snippet to match the tab contents

Reviews

  • Technical review
  • Editorial review
  • Product review

The code snippet for Dockerfile under the "Using the official Docker images" contains a comment which says that this Docker file uses DHI image, which is incorrect.
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 18, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit d67fbdc
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69e359fbac183600081fada7
😎 Deploy Preview https://deploy-preview-24820--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

Comment on lines -149 to 150
# This Dockerfile uses Docker Hardened Images (DHI) for enhanced security.
# For more information, see https://docs.docker.com/dhi/
# This Dockerfile uses Python Docker Official Image
ARG PYTHON_VERSION=3.12
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick check where this came from, but looks like it landed in the wrong tab when this file was updated; https://github.com/docker/docs/pull/23749/changes#diff-8220f5dd3cc751cccded6014817c5369e9d6bc004ec49478bdab02d0629d3d25R149-R151

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Apr 18, 2026

@dvdksn wondering if we should either adjust the length of the collapsed examples

Currently the "preview" only shows comments, and the FROM is not shown, so the two tabs look almost identical;

Screenshot 2026-04-18 at 13 05 35

Or perhaps remove the comment about the Dockerfile being ... annotated with comments, which feels a bit self-describing (I guess these were based on the docker init generated ones though)

Screenshot 2026-04-18 at 13 19 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants