Skip to content

Don't add useless labels which will bother changelog generation#37267

Open
lunny wants to merge 1 commit intogo-gitea:mainfrom
lunny:lunny/better_changelog
Open

Don't add useless labels which will bother changelog generation#37267
lunny wants to merge 1 commit intogo-gitea:mainfrom
lunny:lunny/better_changelog

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Apr 17, 2026

When generating release notes for v1.26, many pull requests haven't been given correct labels so that I have to do many manual work. I think this could be avoid to remove these useless modify labels.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2026
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 17, 2026

Can't we just ignore modifies/* labels in that changelog tool? Where is it?

I do find these labels somewhat useful, but not overly so.

@lunny
Copy link
Copy Markdown
Member Author

lunny commented Apr 18, 2026

Can't we just ignore modifies/* labels in that changelog tool? Where is it?

I do find these labels somewhat useful, but not overly so.

The problem is maintainers will forget to add correct labels once modify labels are added. The changelog tool itself never read modify labels because they cannot be used to generate changelogs.

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 18, 2026

Maybe we should just use AI to generate the changelog. Will probably be much more accurate then those labels will ever be because almost no one sets them correctly.

I don't think I can approve removing all these labels, they could be slimmed down considerable, but outright removal is too much imho.

Can you manually fix this up for v1.26 or do you absolutely need it now?

@lunny
Copy link
Copy Markdown
Member Author

lunny commented Apr 18, 2026

Maybe we should just use AI to generate the changelog. Will probably be much more accurate then those labels will ever be because almost no one sets them correctly.

I don't think I can approve removing all these labels, they could be slimmed down considerable, but outright removal is too much imho.

Can you manually fix this up for v1.26 or do you absolutely need it now?

Could you have some real usages for these labels? I don't know how will you use these labels and how many users/maintainers will use these labels.

@silverwind
Copy link
Copy Markdown
Member

They give me a overview what a PR touches. When commits are pushed, it's often nice validation to see labels being added/removed.

@lunny
Copy link
Copy Markdown
Member Author

lunny commented Apr 18, 2026

They give me a overview what a PR touches. When commits are pushed, it's often nice validation to see labels being added/removed.

If you are using AI, it can have a summary for which files changed on the PR description which is more useful than these labels.

i.e. What could you know from label modifies/internal? Or modifies/frontend?

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 18, 2026

Those 2 are useless, especially internal is ambiguous and should be dropped. modifies/go for example is somewhat useful. I could live with these 4 only:

  • modifies/go
  • modifies/ts
  • modifies/css
  • modifies/templates

But no hard blocker I guess. If more people agree to remove all, I'm fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants