Skip to content

docs: trigger image-builder presubmit validation#13168

Open
Srishti-j18 wants to merge 1 commit intokubernetes-sigs:masterfrom
Srishti-j18:testing-test-infra-new-job
Open

docs: trigger image-builder presubmit validation#13168
Srishti-j18 wants to merge 1 commit intokubernetes-sigs:masterfrom
Srishti-j18:testing-test-infra-new-job

Conversation

@Srishti-j18
Copy link
Copy Markdown
Contributor

@Srishti-j18 Srishti-j18 commented Apr 13, 2026

What type of PR is this?

/kind test

What this PR does / why we need it:
This PR makes a small documentation-only change under test-infra/image-builder/ to verify that the new pull-kubespray-kubevirt-image-builder-validate presubmit appears and runs on Kubespray PRs.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

This is to validate the newly merged Prow presubmit job from:

Does this PR introduce a user-facing change?:

NONE

Copilot AI review requested due to automatic review settings April 13, 2026 10:10
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Srishti-j18
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ant31 and yankay April 13, 2026 10:11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Srishti-j18. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documentation-only change to clarify that the test-infra/image-builder validation make targets correspond to what’s exercised by the Kubespray image-builder presubmit validation.

Changes:

  • Add a note in the CI Validation section indicating the validate targets are used by the Kubespray image-builder presubmit job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Srishti-j18
Copy link
Copy Markdown
Contributor Author

Srishti-j18 commented Apr 13, 2026

need /ok-to-test

@Srishti-j18
Copy link
Copy Markdown
Contributor Author

/cc @tico88612 @VannTen @yankay

@tico88612
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2026
@Srishti-j18
Copy link
Copy Markdown
Contributor Author

/retest-failed

@Srishti-j18
Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@Srishti-j18: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubespray-kubevirt-image-builder-validate b1fadf9 link true /test pull-kubespray-kubevirt-image-builder-validate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Srishti-j18
Copy link
Copy Markdown
Contributor Author

The new presubmit is now triggering correctly on a Kubespray PR, but it fails when running make validate-single image_name=ubuntu-2404 because the job cannot reach the configured builder host from hosts.ini (image-builder-1 shows as unreachable). So the current blocker is builder-host access from the Prow environment, not the presubmit wiring itself.

@VannTen
Copy link
Copy Markdown
Contributor

VannTen commented Apr 14, 2026

Could we use a build tool which does not require docker daemon access or other privileges ?
For example in .gitlab-ci/build.yml we're using moby/buildkit:rootless which works well, and doesn't require any access to another builder.

@Srishti-j18
Copy link
Copy Markdown
Contributor Author

That sounds like a better direction.

The current blocker is that the presubmit depends on SSH access to the remote builder host from hosts.ini, which Prow does not have. Running the validation locally inside CI would avoid that dependency and fit Prow much better.

The current validation flow does more than just the container build, though. It also:

  • downloads the cloud image
  • converts/resizes it with qemu-img
  • then builds the container image

So I’ll look into whether we can adapt the validation flow to run locally in CI, including theqemu-imgpart, or whether that flow should be split. I’ll take that up as the next follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants