docs: trigger image-builder presubmit validation#13168
docs: trigger image-builder presubmit validation#13168Srishti-j18 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Srishti-j18 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Srishti-j18. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Documentation-only change to clarify that the test-infra/image-builder validation make targets correspond to what’s exercised by the Kubespray image-builder presubmit validation.
Changes:
- Add a note in the CI Validation section indicating the
validatetargets are used by the Kubespray image-builder presubmit job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
need |
|
/ok-to-test |
|
/retest-failed |
|
/retest |
|
@Srishti-j18: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The new presubmit is now triggering correctly on a Kubespray PR, but it fails when running |
|
Could we use a build tool which does not require docker daemon access or other privileges ? |
|
That sounds like a better direction. The current blocker is that the presubmit depends on SSH access to the remote builder host from hosts.ini, which Prow does not have. Running the validation locally inside CI would avoid that dependency and fit Prow much better. The current validation flow does more than just the container build, though. It also:
So I’ll look into whether we can adapt the validation flow to run locally in CI, including the |
What type of PR is this?
/kind test
What this PR does / why we need it:
This PR makes a small documentation-only change under
test-infra/image-builder/to verify that the newpull-kubespray-kubevirt-image-builder-validatepresubmit appears and runs on Kubespray PRs.Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
This is to validate the newly merged Prow presubmit job from:
Does this PR introduce a user-facing change?: