OCPBUGS-83598: Add missing generateIPAMLifecycle in ClusterUDN manifest#31020
OCPBUGS-83598: Add missing generateIPAMLifecycle in ClusterUDN manifest#31020mkowalski wants to merge 1 commit intoopenshift:release-4.22from
Conversation
|
@mkowalski: This pull request references Jira Issue OCPBUGS-83598, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview |
|
@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f1e3b5f0-39a7-11f1-8571-c9065f2e2db7-0 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…efinedNetwork manifest The generateClusterUserDefinedNetworkManifest function was missing the generateIPAMLifecycle call, unlike its counterpart generateUserDefinedNetworkManifest. This caused ClusterUserDefinedNetwork manifests to be generated without IPAM lifecycle configuration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7d1ba60 to
4f0eb62
Compare
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview |
|
@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/84b48120-39b2-11f1-89d9-5272686afee4-0 |
|
@mkowalski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview |
|
@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7148e720-39d0-11f1-87ee-95dde2c2064f-0 |
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-5.0-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview |
|
@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16fee6d0-39d4-11f1-8a35-70ab668f70cc-0 |
Summary
generateIPAMLifecycle(params)call ingenerateClusterUserDefinedNetworkManifest, matching the existing pattern ingenerateUserDefinedNetworkManifestClusterUserDefinedNetworkmanifests were generated without IPAM lifecycle configurationTest plan
ClusterUserDefinedNetworkmanifests now include IPAM lifecycle configuration when specifiedUserDefinedNetworkmanifest generation is unaffected🤖 Generated with Claude Code