Skip to content

OCPBUGS-83598: Add missing generateIPAMLifecycle in ClusterUDN manifest#31020

Open
mkowalski wants to merge 1 commit intoopenshift:release-4.22from
mkowalski:OCPBUGS-83598-4.22
Open

OCPBUGS-83598: Add missing generateIPAMLifecycle in ClusterUDN manifest#31020
mkowalski wants to merge 1 commit intoopenshift:release-4.22from
mkowalski:OCPBUGS-83598-4.22

Conversation

@mkowalski
Copy link
Copy Markdown
Contributor

Summary

  • Added missing generateIPAMLifecycle(params) call in generateClusterUserDefinedNetworkManifest, matching the existing pattern in generateUserDefinedNetworkManifest
  • Without this fix, ClusterUserDefinedNetwork manifests were generated without IPAM lifecycle configuration

Test plan

  • Verify ClusterUserDefinedNetwork manifests now include IPAM lifecycle configuration when specified
  • Verify existing UserDefinedNetwork manifest generation is unaffected
  • Run network segmentation e2e tests

🤖 Generated with Claude Code

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mkowalski: This pull request references Jira Issue OCPBUGS-83598, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-83598 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Added missing generateIPAMLifecycle(params) call in generateClusterUserDefinedNetworkManifest, matching the existing pattern in generateUserDefinedNetworkManifest
  • Without this fix, ClusterUserDefinedNetwork manifests were generated without IPAM lifecycle configuration

Test plan

  • Verify ClusterUserDefinedNetwork manifests now include IPAM lifecycle configuration when specified
  • Verify existing UserDefinedNetwork manifest generation is unaffected
  • Run network segmentation e2e tests

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 18db071c-65bc-4e0a-91fd-414da31d54e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mkowalski
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f1e3b5f0-39a7-11f1-8571-c9065f2e2db7-0

@openshift-ci openshift-ci bot requested review from arghosh93 and tssurya April 16, 2026 15:21
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…efinedNetwork manifest

The generateClusterUserDefinedNetworkManifest function was missing the
generateIPAMLifecycle call, unlike its counterpart
generateUserDefinedNetworkManifest. This caused ClusterUserDefinedNetwork
manifests to be generated without IPAM lifecycle configuration.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mkowalski mkowalski force-pushed the OCPBUGS-83598-4.22 branch from 7d1ba60 to 4f0eb62 Compare April 16, 2026 16:36
@mkowalski
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/84b48120-39b2-11f1-89d9-5272686afee4-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mkowalski
Copy link
Copy Markdown
Contributor Author

/payload-job e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7148e720-39d0-11f1-87ee-95dde2c2064f-0

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 16, 2026

/payload-job periodic-ci-openshift-ovn-kubernetes-release-5.0-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-ovn-kubernetes-release-5.0-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16fee6d0-39d4-11f1-8a35-70ab668f70cc-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants