fix: ensure .gitignore is excluded from scanning [PS-571]#64
Draft
alexandru-manea-snyk wants to merge 1 commit intomainfrom
Draft
fix: ensure .gitignore is excluded from scanning [PS-571]#64alexandru-manea-snyk wants to merge 1 commit intomainfrom
alexandru-manea-snyk wants to merge 1 commit intomainfrom
Conversation
|
|
alexandru-manea-snyk
force-pushed
the
fix/PS-571/ensure-gitignore-files-is-excluded-from-upload
branch
from
c6e9e25 to
0fd9741
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a rule to exclude
.gitignorefiles from scanning.Where should the reviewer start?
pkg/filefilter/file_filter_test.go:TestFilter_Logic.MustExcludeFilesilustrates our desired behaviour.How should this be manually tested?
Run the
cmd/develop/main.gotest on a folder containing only .gitignore. You should seeNo supported files founderror.What are the relevant tickets?
Risk assessment (Low | Medium | High)?
Low - this is intentional
Any background context you want to provide?
Screenshots (if appropriate)