Update Migrate4_5_2.java to allow for log4j2-cli.properties not being present#6327
Open
bfnoling wants to merge 1 commit intonextgenhealthcare:release/4.5.2from
Open
Update Migrate4_5_2.java to allow for log4j2-cli.properties not being present#6327bfnoling wants to merge 1 commit intonextgenhealthcare:release/4.5.2from
bfnoling wants to merge 1 commit intonextgenhealthcare:release/4.5.2from
Conversation
Added a check to see if log4j2-cli.properties exists before adding it to the builder. Not having the CLI installed is a valid use case.
tonygermano
added a commit
to rogin/engine
that referenced
this pull request
Nov 23, 2025
Verify that log4j2.properties and log4j2-cli.properties files exist before attempting to update them. These files are not strictly required. Log an INFO level message and continue when not found. Also refactored to elimitate duplication of code. Issue: nextgenhealthcare/connect#6327 Co-authored-by: bfnoling <107218487+bfnoling@users.noreply.github.com> Co-authored-by: Tony Germano <tony@germano.name> Signed-off-by: Richard Ogin <rogin@users.noreply.github.com> Signed-off-by: Tony Germano <tony@germano.name>
jonbartels
pushed a commit
to jonbartels/oie-engine
that referenced
this pull request
Dec 3, 2025
Verify that log4j2.properties and log4j2-cli.properties files exist before attempting to update them. These files are not strictly required. Log an INFO level message and continue when not found. Also refactored to elimitate duplication of code. Issue: nextgenhealthcare/connect#6327 Co-authored-by: bfnoling <107218487+bfnoling@users.noreply.github.com> Co-authored-by: Tony Germano <tony@germano.name> Signed-off-by: Richard Ogin <rogin@users.noreply.github.com> Signed-off-by: Tony Germano <tony@germano.name>
jonbartels
pushed a commit
to jonbartels/oie-engine
that referenced
this pull request
Dec 3, 2025
Verify that log4j2.properties and log4j2-cli.properties files exist before attempting to update them. These files are not strictly required. Log an INFO level message and continue when not found. Also refactored to elimitate duplication of code. Issue: nextgenhealthcare/connect#6327 Co-authored-by: bfnoling <107218487+bfnoling@users.noreply.github.com> Co-authored-by: Tony Germano <tony@germano.name> Signed-off-by: Richard Ogin <rogin@users.noreply.github.com> Signed-off-by: Tony Germano <tony@germano.name>
jonbartels
pushed a commit
to jonbartels/oie-engine
that referenced
this pull request
Dec 3, 2025
Verify that log4j2.properties and log4j2-cli.properties files exist before attempting to update them. These files are not strictly required. Log an INFO level message and continue when not found. Also refactored to elimitate duplication of code. Issue: nextgenhealthcare/connect#6327 Co-authored-by: bfnoling <107218487+bfnoling@users.noreply.github.com> Co-authored-by: Tony Germano <tony@germano.name> Signed-off-by: Richard Ogin <rogin@users.noreply.github.com> Signed-off-by: Tony Germano <tony@germano.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check to see if log4j2-cli.properties exists before adding it to the builder. Not having the CLI installed is a valid use case. I had my 4.5.1 to 4.5.2 upgrade fail if the log4j2-cli.properties file was not in the /conf directory.